Skip to content

Conversation

@jhdcruz
Copy link
Contributor

@jhdcruz jhdcruz commented Nov 8, 2018

build status aligned to the center

build status aligned to the center
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 9, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Nov 9, 2018

@daiyam why downvote it?

@daiyam
Copy link
Contributor

daiyam commented Nov 9, 2018

Well, the badges are usually on the left. And the link is missing.

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Nov 9, 2018

@daiyam In my opinion, centering the badges is not a bad idea. It looks quite nice actually, especially when the previous information is centered. Take a look at one of my repo: https://github.com/ZeroX-DG/SnippetStore (No, I'm not advertising my repo)

@daiyam
Copy link
Contributor

daiyam commented Nov 9, 2018

why not with more badges 😉

@jhdcruz
Copy link
Contributor Author

jhdcruz commented Nov 9, 2018

@daiyam oh yep, I forgot to fix the link 😓

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Dec 6, 2018

@daiyam can we agree with the idea of centering the badges or do you have any other ideas?

@daiyam
Copy link
Contributor

daiyam commented Dec 6, 2018

@ZeroX-DG yes, I'm ok with the centered badge.
@jhdcruz can you fix the link 😉

@jhdcruz
Copy link
Contributor Author

jhdcruz commented Dec 7, 2018

@daiyam on it.

@jhdcruz
Copy link
Contributor Author

jhdcruz commented Dec 7, 2018

@daiyam Done 👍

@jhdcruz jhdcruz closed this Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants