Skip to content

Conversation

@danmou
Copy link
Contributor

@danmou danmou commented Oct 27, 2018

#2197 didn't add the tilde, used for strikethrough, and the alternative italic/bold underscore. Adding the underscore might be a bit annoying to some, but it's only a problem if you want to start a word with underscore (and you can always delete the extra underscore of course).

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 28, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Mar 4, 2019

@danmou very sorry for the late review, can you resolve the conflict?

@danmou
Copy link
Contributor Author

danmou commented Mar 4, 2019

Done.

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 4, 2019
@Rokt33r Rokt33r merged commit 9f13645 into BoostIO:master Mar 20, 2019
@Rokt33r Rokt33r removed approved 👍 Pull request has been approved by sufficient reviewers. labels Mar 20, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants