Add button clear all checkboxes #2503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ZeroX-DG
requested changes
Oct 17, 2018
Member
ZeroX-DG
left a comment
ZeroX-DG
left a comment
There was a problem hiding this comment.
Please change your code according to my request.
| TodoListPercentage.propTypes = { | ||
| percentageOfTodo: PropTypes.number.isRequired | ||
| percentageOfTodo: PropTypes.number.isRequired, | ||
| onClick: PropTypes.func.isRequired |
Member
There was a problem hiding this comment.
I don't think onClick is a good name, I think you should rename it to something like onClearCheckboxClick?
Contributor
Author
There was a problem hiding this comment.
Thanks for your review.
I fix it.
ZeroX-DG
added
awaiting changes 🖊️
ZeroX-DG
approved these changes
Oct 19, 2018
Member
ZeroX-DG
left a comment
ZeroX-DG
left a comment
There was a problem hiding this comment.
LGTM 🎉 Thank you for your contribution
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.11)
and removed
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds button un-check all checkboxes (issue #975)