alternate background color for table rows #2476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroX-DG
added
awaiting review ❇️
Member
|
Should we append css to all CodeMirror themes? Or can we just include another separate css file for that? UPDATE Sorry, my fingers moved faster than my brain haha 😄 |
ZeroX-DG
requested changes
Oct 9, 2018
Member
ZeroX-DG
left a comment
ZeroX-DG
left a comment
There was a problem hiding this comment.
The color is a bit hard to see on dark theme like 3024 night theme. Can you improve it?
Contributor
Author
|
@ZeroX-DG I've updated how to calculate the alternative color. Now, it's used a mix of the background color with a little bit of the text color. |
Member
|
LGTM 👍 |
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.10)
and removed
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change alternates the background color of the table rows.