disable hyperlink for attachments #2474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehhc
reviewed
Oct 9, 2018
| const match = /^\((.*)\)|\[(.*)\]|(.*)$/.exec(el.textContent) | ||
| return match[1] || match[2] || match[3] | ||
| const url = match[1] || match[2] || match[3] | ||
| return /^:storage\//.test(url) ? null : url |
Contributor
There was a problem hiding this comment.
do you mind to use attachmentManagement.STORAGE_FOLDER_PLACEHOLDER instead of hard-coding :storage here?
Contributor
Author
There was a problem hiding this comment.
@ehhc it's not possible
require('../browser/main/lib/dataApi/attachmentManagement') throws the error Cannot find module 'browser/lib/findStorage'
hyperlink.js is loaded by Chromium
attachmentManagement.js is written to be loaded by node
Contributor
There was a problem hiding this comment.
if it is really not possible (i am not a nodejs/electron pro, so i'm not sure about that) could you at least add an comment pointing to that file? That would help a lot in case somebody will refactor it again (e.g. in a few years..)
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.11)
and removed
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables the following popover on attached images:
