Skip to content

Fix Cmd+Left to go to start of visual line on Mac #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rscott wants to merge 1 commit into from
Closed

Fix Cmd+Left to go to start of visual line on Mac #2466

rscott wants to merge 1 commit into from

Conversation

@rscott
Copy link
Contributor

@rscott rscott commented Oct 4, 2018

Addresses #2427

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 5, 2018
@rscott rscott changed the title Fix Cmd+Right to go to end of line on Mac Fix Cmd+Left to go to start of visual line on Mac Oct 6, 2018
@rscott
Copy link
Contributor Author

rscott commented Oct 6, 2018

I misread the issue previously and implemented the opposite of the proposed fix. I realized that today and have changed it to #2427's actual request.

@ZeroX-DG ZeroX-DG requested a review from Rokt33r October 13, 2018 02:31
Rokt33r
Rokt33r requested changes Nov 6, 2018
View reviewed changes
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rscott Looks good! But, could you discard the changes in yarn.lock?

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 6, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Dec 6, 2018

@rscott can you update your PR?

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Dec 23, 2018

@rscott ping!

@Rokt33r Rokt33r mentioned this pull request Dec 24, 2018
Merged
@Rokt33r
Copy link
Member

Rokt33r commented Dec 24, 2018

I've fixed it. #2746

@Rokt33r Rokt33r closed this Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rokt33r Rokt33r Rokt33r requested changes

Assignees

No one assigned

Labels

awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rscott @ZeroX-DG @Rokt33r @kazup01