Cannot search by Chinese #2433
Closed
Cannot search by Chinese #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIFChen
force-pushed
the
cannot-search-by-chinese
branch
from
18375e1 to
3bae4c7
Compare
Contributor
|
doesn't work as expected. |
2 tasks
Contributor
Contributor
I confirmed that current master works perfect. This PR should be closed. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "compositionend" listener to check when done typing Chinese, Japanese, or Korean words.
Result GIF:
http://recordit.co/iLSWqBhJY9
This is a PR for fixing this issue:
#2010
https://issuehunt.io/repos/53266139/issues/2010
Reference:
https://developer.mozilla.org/en-US/docs/Mozilla/IME_handling_guide
https://codepen.io/CarterTsai/pen/IFnGz
https://developer.mozilla.org/en-US/docs/Web/Events/compositionend