Links are clickable #2382
Merged
Links are clickable #2382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroX-DG
requested changes
Sep 9, 2018
| } | ||
| onMouseDown(e) { | ||
| const { target, metaKey } = e | ||
| if (!metaKey) { |
Member
There was a problem hiding this comment.
On Macintosh keyboards, this is the ⌘ Command key. On Windows keyboards, this is the Windows key (⊞ Windows).
I don't know how it looks on MacOS but on Windows and Linux, the meta key is used to open the main menu therefore when you hit meta key + click link, the link does open in the browser but the menu is also displayed which is quite annoying.
I think you will have to change this key to something else. Also you can't set it to ctrl on windows and linux as it's the key for multi-cursor in codemirror. Shift perhaps?
Contributor
Author
|
@ZeroX-DG oops, my bad. I've fixed it. |
ZeroX-DG
added
next release (v0.11.10)
and removed
awaiting review ❇️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes allows to click on links in the editor (like in VS Code).