fixing inline html #2342
Merged
fixing inline html #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- correctly parse self-closed tag - fix naughty functions
Closed
Rokt33r
requested changes
Sep 15, 2018
Member
Rokt33r
left a comment
Rokt33r
left a comment
There was a problem hiding this comment.
LGTM. Is it possible to create some tests for this?
Rokt33r
added
awaiting changes 🖊️
Contributor
Author
|
@Rokt33r I've added a test and fixed a bug found due to it. |
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.12)
and removed
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue #1992.
The issue was due to an incompatibility between
markdown-itandsanitize-html.markdown-itis splitting<kbd>Ctrl</kbd>in 3 parts<kbd>,Ctrland</kbd>.The opening and closing parts were then given to
sanitize-htmlwhich corrects each string to valid html.<kbd>became<kbd></kbd>.<kbd>became empty.So
<kbd>Ctrl</kbd>became<kbd></kbd>Ctrl