Spellchecker #2338
Merged
Spellchecker #2338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ell_check # Conflicts: # browser/components/CodeEditor.js # locales/fr.json # package.json
|
Is this still active? |
Contributor
Author
|
@nac2791 if i understand it right, the maintainer (@Rokt33r ) decided that my solution is too complex and will not be merged therefore. |
Member
|
Alright. I changed my mind. Let's give a shot. @ehhc Could you fix the conflicts? |
Rokt33r
added
awaiting changes 🖊️
Rokt33r
added
awaiting review ❇️
Contributor
Author
|
@Rokt33r the conflicts are resolved :) |
Rokt33r
added
approved 👍
Member
|
I'm going to merge this after releasing v0.11.11! Thanks for your effort! |
Rokt33r
added
next release (v0.11.12)
and removed
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another try to add spellcheck to boostnote.
The live spell check is debounced now..
Unfortunately the context menu is buggy if it is invoked from the keyboard and not with the mouse.. I have absolutely no idea why that happens.. Maybe it's enough to be merged anyway @Rokt33r ?