Skip to content

Conversation

@amedora
Copy link
Contributor

@amedora amedora commented Jul 23, 2018

this PR resolves #1454
ditaa

@amedora
Copy link
Contributor Author

amedora commented Jul 23, 2018

oh wait, markdown-it-plantuml now supports Ditaa. See gmunguia/markdown-it-plantuml#9
I will update this implementation later.

@amedora
Copy link
Contributor Author

amedora commented Jul 23, 2018

The code looks ok bacause we are manually define generateSource property that should be also necessary for markdown-it-plantuml v1.2.0.

@Rokt33r Rokt33r added next release (v0.11.9) and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 9, 2018
@Rokt33r Rokt33r merged commit cc26fd8 into BoostIO:master Aug 9, 2018
@amedora amedora deleted the feature/1454-ditaa branch August 16, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add Ditaa support to current Diagram support

2 participants