Skip to content

Add Ctrl+I and Ctrl+B support to format text #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noelzubin wants to merge 2 commits into from
Closed

Add Ctrl+I and Ctrl+B support to format text #2180

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17f0a04
Add Ctrl+I and Ctrl+B support to format text
noelzubin Jul 4, 2018
49e173e
refacor code; fix linting; add mac support
noelzubin Jul 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions browser/components/CodeEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,69 @@ export default class CodeEditor extends React.Component {
'Cmd-T': function (cm) {
// Do nothing
},
'Ctrl-I': function(cm) {
Copy link
Member

@Rokt33r Rokt33r Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For macOS, we have to implement this to Cmd-I and Cmd-B.
So, we have to extract the handler and make it work depending on OS.
Like the below:

'Cmd-I': function (cm) {
  if (global.process.platform !== 'darwin') { return }
  applyItalic(cm)
},
'Ctrl-I': function (cm) {
  if (global.process.platform === 'darwin') { return }
  applyItalic(cm)
}

if(cm.somethingSelected()) {
let selection = cm.getSelection()
let str = selection.trim()
let index = selection.indexOf(str)

if(str.length === 0 || str.match(/\n\s*\n/) !== null)
return

let newString
let boldAndItalic = str.match(/^\*\*\*(.*)\*\*\*$/)
let bold = str.match(/^\*\*(.*)\*\*$/)
let italic = str.match(/^\*(.*)\*$/)
if(boldAndItalic !== null) {
newString = boldAndItalic[1]
newString = `**${newString}**`
} else if(bold !== null) {
newString = bold[1]
newString = `***${newString}***`
} else if(italic !== null) {
newString = italic[1]
newString = newString
} else {
newString = `*${str}*`
}

let newSelection = selection.substr(0, index) + newString + selection.substr(index + selection.length)
cm.replaceSelection(newSelection)
}
},
'Ctrl-B': function(cm) {
Copy link
Member

@Rokt33r Rokt33r Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same to here

if(cm.somethingSelected()) {
let selection = cm.getSelection()
let str = selection.trim()
let index = selection.indexOf(str)

if(str.length === 0 || str.match(/\n\s*\n/) !== null)
return

let newString
let boldAndItalic = str.match(/^\*\*\*(.*)\*\*\*$/)
let bold = str.match(/^\*\*(.*)\*\*$/)
let italic = str.match(/^\*(.*)\*$/)
if(boldAndItalic !== null) {
newString = boldAndItalic[1]
newString = `*${newString}*`
} else if(bold !== null) {
newString = bold[1]
newString = newString
} else if(italic !== null) {
newString = italic[1]
newString = `***${newString}***`
} else {
newString = `**${str}**`
}

let newSelection = selection.substr(0, index) + newString + selection.substr(index + selection.length)
cm.replaceSelection(newSelection)
}
},
Enter: 'boostNewLineAndIndentContinueMarkdownList',
'Ctrl-C': (cm) => {
console.log('here', cm)
Copy link
Member

@Rokt33r Rokt33r Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this unnecessary logging

if (cm.getOption('keyMap').substr(0, 3) === 'vim') {
document.execCommand('copy')
}
Expand Down