Skip to content

Fix search value for html export path #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rokt33r merged 2 commits into from
Aug 9, 2018
Merged

Fix search value for html export path #2171

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f79f52
Fix search value for html export path
yamash723 Jul 3, 2018
ee6b9a2
Change output path format of html file by platform
yamash723 Jul 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser/components/MarkdownPreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export default class MarkdownPreview extends React.Component {
const attachmentsAbsolutePaths = attachmentManagement.getAbsolutePathsOfAttachmentsInContent(noteContent, this.props.storagePath)

files.forEach((file) => {
file = file.replace('file://', '')
file = file.replace('file:///', '')
Copy link
Member

@Rokt33r Rokt33r Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix doesn't work on macOS. I think we have to check which os is used.

if (global.process.platform === 'win32') {
  file = file.replace('file:///', '')
} else {
  file = file.replace('file://', '')
}

Copy link
Contributor Author

@yamash723 yamash723 Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. I fixed it.

exportTasks.push({
src: file,
dst: 'css'
Expand Down