Add collapsed state for storage #2144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2018
sosukesuzuki
requested changes
Jun 29, 2018
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
Thanks for your contribution:+1:
Please confirm my review!
browser/main/SideNav/StorageItem.js
Outdated
| .then((storage) => { | ||
| dispatch({ | ||
| type: 'EXPAND_STORAGE', | ||
| storage: storage, |
Member
There was a problem hiding this comment.
please write like below:
dispatch({
type: 'EXPAND_STORAGE',
storage,
isOpen
})
sosukesuzuki
approved these changes
Jun 29, 2018
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
I'll merge this PR after release next version(v0.11.7)!
sosukesuzuki
added
next release (v0.11.8)
and removed
awaiting review ❇️
Contributor
Author
|
@sosukesuzuki Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of this issue is that when the folder is clicked,
the router pushed the path and the StorageItem component has been
refreshed and isOpen has been reset
fix #1979 #1911