Skip to content

Conversation

@kawmra
Copy link
Contributor

@kawmra kawmra commented Jun 9, 2018

The text of Support via OpenCollective button in Crowdfunding tab is clipped when setting language to Japanese because the width of the button is fixed to 250px.

I think it is better to set paddings to left and right instead of fixing width.

Before

2018-06-09 20 17 31

After

2018-06-09 20 17 52

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Jun 10, 2018
@kazup01 kazup01 self-requested a review June 11, 2018 05:25
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 13c37f0 into BoostIO:master Jun 11, 2018
@kazup01
Copy link
Member

kazup01 commented Jun 11, 2018

Merged. Thanks @kawmra :)

@kazup01 kazup01 added next release (v0.11.7) and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 11, 2018
@kawmra kawmra deleted the fix-crowdfunding-button-style branch June 17, 2018 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants