Added custom markdown css #1996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sosukesuzuki
requested changes
Jun 1, 2018
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
@ZeroX-DG
Please confirm my review!
| {i18n.__('Custom CSS')} | ||
| </div> | ||
| <div styleName='group-section-control'> | ||
| <ReactCodeMirror onChange={e => this.handleUIChange(e)} ref={e => (this.customCSSCM = e)} value={config.preview.customCSS} options={{ lineNumbers: true, mode: 'css', theme: codemirrorTheme }} /> |
Member
There was a problem hiding this comment.
This ReactCodeMirror is too huge...
Set the width of this according to the editor.
Member
Author
|
@sosukesuzuki I have changed my code, please have a look 😃 |
sosukesuzuki
approved these changes
Jun 4, 2018
sosukesuzuki
added
next release (v0.11.5)
and removed
awaiting review ❇️
|
Suggest define Custom CSS as multiple theme, and user can associate different notes with different CSS themes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this feature, users can now customize how the markdown should look like. More info: https://issuehunt.io/repos/53266139/issues/184
Here is how it looks
As you can see, the user can choose to use custom css or not by clicking on the allow custom css checkbox in the preview section and then specify the custom css in the code editor bellow.
By default the custom css is disabled.
If the user export the note as html, their custom style will be applied too.