Fix legacy attachment issues #1949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
requested changes
May 28, 2018
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
please confirm my review.
| createAttachmentDestinationFolder(storagePath, noteKey) | ||
| } | ||
| for (const attachment of attachments) { | ||
| let attachmentBaseName = path.basename(attachment) |
Contributor
Author
There was a problem hiding this comment.
you are right and i've fixed the issue like you suggested
Contributor
Author
There was a problem hiding this comment.
you are right and i've fixed the issue like you suggested
kazup01
added
awaiting changes 🖊️
Contributor
Author
|
@sosukesuzuki i did like you said :) |
Contributor
Author
|
@kazup01 could you change it to "in review" again? Maybe you can do a review as well? |
kazup01
added
awaiting review ❇️
sosukesuzuki
force-pushed
the
Fix_legacy_attachment_issues
branch
from
bb331c8 to
ffae533
Compare
sosukesuzuki
approved these changes
Jun 4, 2018
kazup01
added
next release (v0.11.5)
and removed
awaiting review ❇️
This was referenced Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.