Fix #1003 Update CodeMirror version #1925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rokt33r
requested changes
May 16, 2018
Member
Rokt33r
left a comment
Rokt33r
left a comment
There was a problem hiding this comment.
Could you exclude package-lock.json? Anyway, thanks for the contributing. 😄
Rokt33r
added
awaiting changes 🖊️
to fix issue#1003
Contributor
Author
|
Thank you for your review ! |
Rokt33r
added
next release (v0.11.5)
and removed
awaiting changes 🖊️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix second point of my comment of issue#1003
CodeMirror released new version which fixed this issue.