fix inconsistent updates to react component state #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executions of setState() may be batched, and so updates to this.state and this.props can be asynchronous, so references to this.state and this.props should not be made in the new state, and instead the callback form of setState() should be used. These alerts were found using lgtm.com: https://lgtm.com/projects/g/BoostIO/Boostnote/alerts/?mode=tree&ruleFocus=1819283066 see: https://reactjs.org/docs/state-and-lifecycle.html#state-updates-may-be-asynchronous
Rokt33r
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executions of
setState()may be batched, and so updates tothis.stateandthis.propscan be asynchronous, so references tothis.stateandthis.propsshould not be made in the new state, and instead the callback form of
setState()should be used.These alerts were found using lgtm.com:
https://lgtm.com/projects/g/BoostIO/Boostnote/alerts/?mode=tree&ruleFocus=1819283066
see: https://reactjs.org/docs/state-and-lifecycle.html#state-updates-may-be-asynchronous
Full disclosure, I work for Semmle on lgtm.com