Edit the localization file of zh-TW #1834

ralphchung · 2018-04-18T08:50:11Z

I'm a Taiwanese user and have edited the zh-TW.json based on the original version.
The use of words in this document is more in keeping with the habits of how Taiwanese use Chinese.

Rokt33r · 2018-04-20T04:34:04Z

@rayou Could you review this?

rayou · 2018-04-20T04:37:35Z

No problem, will do this weekend.

…

On Fri, 20 Apr 2018 at 2:34 pm, Junyoung Choi (Sai) < ***@***.***> wrote: @rayou <https://github.com/rayou> Could you review this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1834 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADA02AGeNDpjWFsNstZrNtrbQ9nq698hks5tqWVBgaJpZM4TZqjt> .

rayou · 2018-04-22T02:02:25Z

locales/zh-TW.json

-	"to create a new note": "新建筆記",
+	"to create a new note": "新增筆記",
 	"Toggle Mode": "切換模式",
 	"Trash": "廢紙簍",


改用垃圾桶比較符合台灣用語

其實這個我看原本翻譯廢紙簍感覺也蠻酷的，不過不否認垃圾桶比較親民一點XD

rayou · 2018-04-22T02:06:03Z

locales/zh-TW.json

+	"Storages": "本機儲存空間",
+	"Add Storage Location": "新增一個本機儲存位置",
+	"Add Folder": "新增資料夾",
+	"Open Storage folder": "開啟一個本機儲存位置",


開啟儲存資料夾

rayou · 2018-04-22T02:07:28Z

locales/zh-TW.json

 	"vim": "vim",
 	"emacs": "emacs",
-	"⚠️ Please restart boostnote after you change the keymap": "⚠️ 設置好快捷鍵後，記得重啟设置好快捷键后，记得重启boostnote",
+	"⚠️ Please restart boostnote after you change the keymap": "⚠️ 請重新開啟 Boostnote 已完成設定。",


rayou · 2018-04-22T02:11:03Z

locales/zh-TW.json

-	"Allow preview to scroll past the last line": "允許預覽器滾動到最後一行",
-	"Show line numbers for preview code blocks": "在預覽器中顯示行號",
+	"Allow editor to scroll past the last line": "允許編輯器捲軸捲動超過最後一行",
+	"Bring in web page title when pasting URL on editor": "在編輯器貼上網址的時候，顯示為網頁標題",


在編輯器貼上網址時，自動添加網頁標題

rayou · 2018-04-22T02:13:30Z

locales/zh-TW.json

+	"Code block Theme": "程式碼區塊主題",
+	"Allow preview to scroll past the last line": "允許預覽頁面捲軸捲動超過最後一行",
+	"Show line numbers for preview code blocks": "在預覽頁面的程式碼區塊中顯示行號",
 	"LaTeX Inline Open Delimiter": "LaTeX 單行開頭分隔符",


分隔符 -> 符號

rayou · 2018-04-22T02:15:06Z

locales/zh-TW.json

+	"An open source note-taking app made for programmers just like you.": "一款專門為程式設計師朋友量身打造的開源筆記軟體",
 	"Website": "官網",
 	"Development": "開發",
 	" : Development configurations for Boostnote.": " : Boostnote的開發配置",


配置 -> 設定

好像應該用 組態 ?

yep, sounds good.

rayou · 2018-04-22T02:16:17Z

locales/zh-TW.json

+	"You can see how it works on ": "你可以看看它的程式碼是如何運作的  ",
+	"You can choose to enable or disable this option.": "你可以選擇啟用或禁用這項功能",
+	"Enable analytics to help improve Boostnote": "允許數據分析以協助我們改進Boostnote",
 	"Crowdfunding": "眾籌",


群眾募資

rayou · 2018-04-22T02:21:24Z

locales/zh-TW.json

 	"Polish": "Polish",
 	"Portuguese": "Portuguese",
 	"Spanish": "Spanish",
 	"You have to save!": "你必須儲存一下！",


rayou · 2018-04-22T02:34:16Z

locales/zh-TW.json

-	"Sanitization": "代碼處理",
+	"Enable": "啟用",
+	"Disable": "禁用",
+	"Sanitization": "消毒",


過濾 HTML 程式碼

rayou · 2018-04-22T02:37:32Z

Hi @ralphchung

Please have a look at my suggestions, happy to discuss.

Thanks

ralphchung · 2018-04-23T11:34:43Z

Thank you @rayou for reviewing and giving suggestions.

Will do this in a few days. BTW, I prefer 廢紙簍 to 垃圾桶. What do you think about this?
Another question, should I add a space between Chinese characters and English characters or other symbols? (my answer is yes!)

Thank you very much again!

rayou · 2018-04-23T11:41:31Z

Hi @ralphchung

I am fine with 廢紙簍, and yes, adding a space between Chinese and English characters increases readability, please make these changes when you're available.

Thanks

I've edited the zh-TW.json based on the original version. The use of words in this document is more in keeping with the habits of how Taiwanese use Chinese.

ralphchung · 2018-04-23T16:56:25Z

@rayou

I've made the changes and slightly modified some other parts of this file. Please have a look again, happy to discuss too!

Thank you very much!

rayou · 2018-04-25T09:16:33Z

@ralphchung LGTM.

…

On Tue, 24 Apr 2018 at 2:56 am, Cheng-Yu Chung ***@***.***> wrote: @rayou <https://github.com/rayou> I've made the changes and slightly modified some other parts of this file. Please have a look again, happy to discuss too! Thank you very much! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1834 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADA02Mpx6JUdyS0tRho6hrse798yN-7nks5trgfAgaJpZM4TZqjt> .

kazup01

LGTM

kazup01 · 2018-04-26T13:19:29Z

Thanks for your contribution @ralphchung 🎉 and for your review @rayou 🍻

Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Apr 20, 2018

rayou reviewed Apr 22, 2018

View reviewed changes

Edit the localization file of zh-TW

a82a79e

I've edited the zh-TW.json based on the original version. The use of words in this document is more in keeping with the habits of how Taiwanese use Chinese.

kazup01 self-requested a review April 26, 2018 13:17

kazup01 approved these changes Apr 26, 2018

View reviewed changes

kazup01 merged commit 6c4aa71 into BoostIO:master Apr 26, 2018

kazup01 added next release (v0.11.5) and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 26, 2018

Uh oh!

Edit the localization file of zh-TW #1834

Edit the localization file of zh-TW #1834

Uh oh!

Conversation

ralphchung commented Apr 18, 2018

Uh oh!

Rokt33r commented Apr 20, 2018

Uh oh!

rayou commented Apr 20, 2018 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rayou commented Apr 22, 2018

Uh oh!

ralphchung commented Apr 23, 2018

Uh oh!

rayou commented Apr 23, 2018

Uh oh!

ralphchung commented Apr 23, 2018

Uh oh!

rayou commented Apr 25, 2018 via email

Uh oh!

kazup01 left a comment

Choose a reason for hiding this comment

Uh oh!

kazup01 commented Apr 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kazup01 commented Apr 26, 2018 •

edited

Loading