Centralized languages into 1 files #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
requested changes
Apr 24, 2018
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
please confirm my reviews!
| <option value='ru'>{i18n.__('Russian')}</option> | ||
| <option value='es-ES'>{i18n.__('Spanish')}</option> | ||
| { | ||
| languages.map((language) => { |
Member
There was a problem hiding this comment.
() for a single argument and return are unnecessary in arrow functions.
please rewrite like below:
languages.map(language =>
<option value={language.locale} key={language.locale}>{i18n.__(language.name)}</option>)
browser/lib/i18n.js
Outdated
| const { app } = remote | ||
| const { languages } = require('./Languages.js') | ||
|
|
||
| let locales = languages.reduce(function (localeList, locale) { |
Member
There was a problem hiding this comment.
locales is never reassigned. Please use const instead of let.
Member
There was a problem hiding this comment.
And this duplicates with this lines.
Please export locales from this file and import locales from this file in browser/main/Main.js.
browser/main/Main.js
Outdated
| 'ru', | ||
| 'es-ES' | ||
| ] | ||
| let locales = languages.reduce(function (localeList, locale) { |
Member
Author
|
@sosukesuzuki please confirm my changes |
Member
|
Good! I'll approve!!:+1: |
sosukesuzuki
approved these changes
Apr 24, 2018
Member
|
Merged. Thank you for amazing contribution @ZeroX-DG ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR centralized all languages into 1 file so that next time you want to add a new language just add it to the Languages.js file.