Skip to content

Conversation

@romainlq
Copy link
Contributor

Noticed the empty issue template so I updated it.

Please let me know what you think, this may need some adjustments 😄

PS : noticed mentionning the need of an issue template in contributing.md. Once the issue template is merged, it might be ideal to update this file as well

@Rokt33r
Copy link
Member

Rokt33r commented Apr 12, 2018

It looks great! But, I agree with @bimlas. I'll merge this after deleting the first 7 lines. 💯

@Rokt33r Rokt33r self-requested a review April 12, 2018 16:50
@Rokt33r Rokt33r added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Apr 12, 2018
@romainlq
Copy link
Contributor Author

Done ! Thanks for the feedback guys 👍

@Rokt33r Rokt33r added next release (v0.11.5) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Apr 14, 2018
@Rokt33r Rokt33r merged commit 02fb1d0 into BoostIO:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants