Add jest and simple test #1752
Merged
Add jest and simple test #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
One big issue I'm thinking about. Jest doesn't work with |
sosukesuzuki
requested changes
Apr 3, 2018
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
I run yarn and yarn run jest, console shows the error like below.
please add jest-localstorage-mock.
Can you detail this? Maybe you are referring to Did you consider adding enzyme? Great job for adding Jest. It's a big and important step for this project! 🎖 |
kazup01
added
awaiting changes 🖊️
sosukesuzuki
approved these changes
Apr 10, 2018
Rokt33r
added
next release (v0.12.0)
and removed
awaiting changes 🖊️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Jest to the project.
There is an issue when you test components with external js libraries. For example,
MarkdownPreviewworks withRaphaeland its' extensions to draw graphs. I haven't figured out yet how to mock these stuff properly.