fix reload crash on /searched #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add routing for search word: - `/searched/:searchword` Restore the state from the `:searchword` params.
azu
commented
Mar 24, 2018
| const { params } = this.props | ||
| const searchWord = params.searchword | ||
| if (searchWord !== undefined) { | ||
| this.setState({ |
Contributor
Author
There was a problem hiding this comment.
Restore search state from /searched/:searchword
| }) | ||
| router.push('/searched') | ||
| const keyword = this.refs.searchInput.value | ||
| router.push(`/searched/${encodeURIComponent(keyword)}`) |
Contributor
Author
There was a problem hiding this comment.
push to /searched/:searchword
| <Route path='starred' /> | ||
| <Route path='searched' /> | ||
| <Route path='searched'> | ||
| <Route path=':searchword' /> |
| } | ||
|
|
||
| if (location.pathname.match(/\/searched/)) { | ||
| const searchInputText = document.getElementsByClassName('searchInput')[0].value |
sosukesuzuki
approved these changes
Mar 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix reloading creash on
/searched#1743Add routing for search word:
/searched/:searchwordRestore the state from the
:searchwordparams.fix #1743