remove broken note from note list #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When .cson is broken and catch error in processing this file, undefined is collected in notes. remved broken note(s) from notes list.
Member
|
LGTM! 久しぶりです！ |
Member
Author
|
@Rokt33r Thanks!またちょこちょこ手伝いますね！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1597 #1485 #1694
I also have same behaviour reported in above issues.
I don't know broken .cson error is made by Boostnote or not, but it is quite scary that notes seems to be disappeared. Investigating the reason why we get the broken the .cson is important, but I think quick fix is more important.
In current implementation, when .cson is broken and catch error in processing this file, undefined is collected in notes. If undefined is in the notes, we cannot see the broken note and following notes even they are not broken.
My implementation is just removing undefined from the note list.