Added unit tests for lib/markdown #1678
Conversation
| const path = require('path') | ||
| const fs = require('sander') | ||
| const { remote } = require('electron') | ||
| const { app } = remote |
There was a problem hiding this comment.
I couldn't extract app from remote while running tests, following error throws.
var app = remote.app;
^
TypeError: Cannot read property 'app' of undefinedAny ideas why this happened?
There was a problem hiding this comment.
I assume we have to make remote Mockable.
There was a problem hiding this comment.
As result, require('electron') just return the path of electron binary, a string.
I think it's an good idea to mock electron, so I created a new mock helper in tests/helpers/setup-electron-mock.js, we can add more mocked function into it if needed.
| }, | ||
| "devDependencies": { | ||
| "ava": "^0.16.0", | ||
| "ava": "^0.25.0", |
There was a problem hiding this comment.
upgraded to 0.25.0 for snapshot support
|
|
||
| function filePath (filename) { | ||
| return path.join('boostnoterc', filename) | ||
| return path.join(`${__dirname}/boostnoterc`, filename) |
… production mode" This reverts commit bbcd674.
|
|
||
| const noop = () => {} | ||
|
|
||
| mock('electron', { |
There was a problem hiding this comment.
added mock electron.
| const path = require('path') | ||
| const fs = require('sander') | ||
| const { remote } = require('electron') | ||
| const { app } = remote |
There was a problem hiding this comment.
As result, require('electron') just return the path of electron binary, a string.
I think it's an good idea to mock electron, so I created a new mock helper in tests/helpers/setup-electron-mock.js, we can add more mocked function into it if needed.
|
As result, I think it's an good idea to mock The change in |
|
Great work!! 👍 👍 👍 |
|
fixed conflicts. |
Rokt33r
added
next release (v0.11.3)
and removed
awaiting review ❇️
2 participants
Added unit tests for the issues in recent releases.