Skip to content

Adds the ability to copy the note link from the note list #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rokt33r merged 2 commits into from
Mar 5, 2018
Merged

Adds the ability to copy the note link from the note list #1583

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5e57e
Adding the ability to copy the note link from the note list
pfftdammitchris Feb 25, 2018
207f956
Merge branch 'master' into copylink-notelist
Rokt33r Mar 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion browser/main/NoteList/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import searchFromNotes from 'browser/lib/search'
import fs from 'fs'
import path from 'path'
import { hashHistory } from 'react-router'
import electron from 'electron'
import copy from 'copy-to-clipboard'
import AwsMobileAnalyticsConfig from 'browser/main/lib/AwsMobileAnalyticsConfig'
import markdown from '../../lib/markdown'

Expand Down Expand Up @@ -73,6 +73,7 @@ class NoteList extends React.Component {
this.getNoteFolder = this.getNoteFolder.bind(this)
this.getViewType = this.getViewType.bind(this)
this.restoreNote = this.restoreNote.bind(this)
this.copyNoteLink = this.copyNoteLink.bind(this)

// TODO: not Selected noteKeys but SelectedNote(for reusing)
this.state = {
Expand Down Expand Up @@ -461,6 +462,7 @@ class NoteList extends React.Component {
const deleteLabel = 'Delete Note'
const cloneNote = 'Clone Note'
const restoreNote = 'Restore Note'
const copyNoteLink = 'Copy Note Link'
const publishLabel = 'Publish Blog'
const updateLabel = 'Update Blog'
const openBlogLabel = 'Open Blog'
Expand Down Expand Up @@ -488,6 +490,10 @@ class NoteList extends React.Component {
label: cloneNote,
click: this.cloneNote.bind(this)
}))
menu.append(new MenuItem({
label: copyNoteLink,
click: this.copyNoteLink(note)
}))
if (note.type === 'MARKDOWN_NOTE') {
if (note.blog && note.blog.blogLink && note.blog.blogId) {
menu.append(new MenuItem({
Expand Down Expand Up @@ -654,6 +660,11 @@ class NoteList extends React.Component {
})
}

copyNoteLink (note) {
const noteLink = `[${note.title}](${note.storage}-${note.key})`
return copy(noteLink)
}

save (note) {
const { dispatch } = this.props
dataApi
Expand Down