Display filename in codeblock (resend) #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
requested changes
Feb 19, 2018
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
Thanks you for your contribution.
please confirm my reviews!
browser/lib/markdown.js
Outdated
| highlight: function (str, lang) { | ||
| let delimiter = ":"; | ||
| let langinfo = lang.split(delimiter); | ||
| let lang = langinfo[0]; |
Member
There was a problem hiding this comment.
duplicate declaration lang
browser/lib/markdown.js
Outdated
| xhtmlOut: true, | ||
| breaks: true, | ||
| highlight: function (str, lang) { | ||
| let delimiter = ":"; |
kazup01
added
awaiting changes 🖊️
Contributor
Author
|
Sorry. I've followed eslintrc. |
Rokt33r
approved these changes
Feb 22, 2018
Rokt33r
added
next release (v0.9.1)
and removed
awaiting changes 🖊️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
! Please reject my former pull request !
I've added a feature displaying file name in code block.
Additionally, I made it possible to define any first line number.
The notation is as follows.
Example:
If you don't write file name and line number, it behaves originally.