Sync Split Editor scroll position #1521
Conversation
|
You can probably bind the scroll of one pane directly to the other by removing the debounce and removing the easing, but since these events are fired per (sub)pixel movement, you can rank up 1000+ events per second on a UHD screen and it didn't seem sane to do so. Feel free to improve or like it as is. |
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
Thanks your for great contribution.
please confirm my review.:pray:
| let f, t | ||
| const timer = setInterval(() => { | ||
| t = (s - i) / s | ||
| f = t < 0.5 ? 2 * t * t : -1 + (4 - 2 * t) * t |
There was a problem hiding this comment.
I want you to rename variables.
Because, it is difficult to understand meaning of s, t, f for me.
And, please refactor for conditional operator, like below.
f = t < 0.5
? 2 * t * t
: -1 + (4 - 2 * t) * t
kazup01
added
awaiting changes 🖊️
|
@sosukesuzuki Thanks for the review. I will address the issues, hopefully before or in the weekend. |
Redsandro
force-pushed
the
scrollsync
branch
from
436b6a8 to
051ccad
Compare
|
@sosukesuzuki Fixed and rebased. Ready when you are. |
Forgot curly brace when merging master
|
Merged |
Rokt33r
added
next release (v0.9.1)
and removed
awaiting changes 🖊️
|
Apparently this in in 0.10.0 but not working for me. Does it have to be enabled somehow? |
|
@gramster Hmm.. there was a problem while merging lots of PRs. Could you create an issue about this? |
|
I noticed it does work from preview window (markdown syncs), but not from markdown window (preview doesn't sync). |
|
NOOB HERE |
|
@nototono Scroll syncing has a bug now. It will be fixed soon. |
6 participants
I have created a low impact delayed debounced scroll sync for the split editor.
This could probably be done better with some modules that allow queueing and animation in order to better catch missed events from rapid scrolling, but I know absolutely nothing about react, so I coded this moon-lander-style. That said, it's already infinitely better than nothing.
This would close #1355.