Skip to content

show delete confirmation dialog #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazup01 merged 5 commits into from
Jan 12, 2018
Merged

show delete confirmation dialog #1324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bba544
show delete confirmation dialog
Dec 21, 2017
aabfe82
refactored to prevent duplicate code
Dec 21, 2017
e262d2f
fixed lint error
Dec 21, 2017
9f9463f
fixed review comments
Jan 3, 2018
18649dd
fixed lint errors
Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions browser/main/Detail/MarkdownNoteDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import striptags from 'striptags'

const electron = require('electron')
const { remote } = electron
Copy link
Member

@sosukesuzuki sosukesuzuki Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remote and electron are unnecessary.

const { dialog } = remote

class MarkdownNoteDetail extends React.Component {
constructor (props) {
Expand Down Expand Up @@ -203,9 +202,11 @@ class MarkdownNoteDetail extends React.Component {
}, () => {
this.save()
})

ee.emit('list:next')
}
}
ee.emit('list:next')

Copy link
Member

@sosukesuzuki sosukesuzuki Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this blank line.

}

handleUndoButtonClick (e) {
Expand Down
3 changes: 2 additions & 1 deletion browser/main/Detail/SnippetNoteDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,10 @@ class SnippetNoteDetail extends React.Component {
}, () => {
this.save()
})

ee.emit('list:next')
}
}
ee.emit('list:next')
}

handleUndoButtonClick (e) {
Expand Down