Skip to content

Conversation

@ytk141
Copy link
Contributor

@ytk141 ytk141 commented Nov 18, 2017

Boostnote Icon Design Update

boostnote icon design update

Sidebar&NoteList

sidebar notelist

NoteDetail__info-right

notedetail__info-right

@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@BoostnoteBot
Copy link
Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@kazup01
Copy link
Member

kazup01 commented Nov 18, 2017

Thank you for your contribution @ytk141 ! I will check it :)

@kazup01 kazup01 self-requested a review November 18, 2017 03:05
boostnote.json Outdated
@@ -0,0 +1,10 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file (boostnote.json) is unnecessary. Could you delete it?

@kazup01 kazup01 self-requested a review November 18, 2017 03:24
@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Nov 18, 2017
@ytk141
Copy link
Contributor Author

ytk141 commented Nov 18, 2017

@kazup01 Updated!

@kazup01
Copy link
Member

kazup01 commented Nov 18, 2017

@ytk141 Thanks!

Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 34c667f into BoostIO:master Nov 18, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 18, 2017

Merged. I will fix CI error soon.
Thank you again @ytk141 🎉

@kazup01 kazup01 added next release (v0.8.17) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. Next Release labels Nov 18, 2017
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants