added shortcut ctrl+q for quit and quit the app when using the Windows Close button #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @mslourens , could you fix CI error? |
Contributor
Author
|
I am not sure why CI failed with the error message:
Can somebody who knows the build process have a look? I just fixed the lint warnings generated by my previous change. |
Member
|
Hi @mslourens , thanks for your check! I could fix it when I restarted the CI. Sorry for your inconvenience. |
Contributor
|
@kazup01 Can you confirm how this PR works? If it is fine, please merge it. |
Member
|
Merged. |
This was referenced Nov 5, 2017
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #997
Changes: