Include each note only once when sorting by pin #1033
Merged
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @nathanielw , thank you for your contribution! We will check it soon. |
Contributor
|
@kazup01 Can you confirm how this PR works? If it is fine, please merge it. |
Member
|
I confirmed. @sota1235 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983
Previously the
sortByPinfunction was getting the pinned notes then preprending them to all the notes, pinned notes included, meaning there were duplicate items in thenotesarray. This caused the "Next Note" functionality to not always work correctly (if the next note was in fact a duplicate of the selected note).This fix filters the notes into "pinned" and "unpinned" then concatenates them together, avoiding duplicates.