Skip to content

Conversation

@ricardoavelino
Copy link

@ricardoavelino ricardoavelino commented Aug 8, 2025

This PR adds the SurfaceModel at the same level of BlockModel.

SurfaceModel will store intrados, extrados, middle meshes and the formdiagram.

It include an extended viewer called MasonryViewer that enables to visualize the Thrust Networks and blocks at the same time.

SurfaceModel works with TNO. You only need to start the analysis with:

from compas_tno.analysis import Analysis
analysis = Analysis.create_minthrust_analysis(model)
(...)
analysis.run()

SurfaceModel is backwards compatible and has interoperability with compas_dem. A block model can be obtained from the formdiagram dual by writing:

blockmodel = surfacemodel.to_blocks()

Perhaps we should create a new package to store SurfaceModel...

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant