Add more s3 fetchers #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donghwikim2
force-pushed
the
s3-fetchers
branch
6 times, most recently
from
711e3bf to
88f539c
Compare
donghwikim2
force-pushed
the
s3-fetchers
branch
from
88f539c to
e21a3bf
Compare
donghwikim2
force-pushed
the
s3-fetchers
branch
from
e21a3bf to
4c4803c
Compare
maxhov
reviewed
Oct 22, 2025
connector/aws/s3/src/main/java/com/blazebit/query/connector/aws/s3/GrantFetcher.java
Outdated
Show resolved
Hide resolved
| try (S3Client client = s3ClientBuilder.build()) { | ||
| for ( Bucket bucket : client.listBuckets().buckets() ) { | ||
| GetBucketLoggingRequest.builder().build(); | ||
| var bucketLogging = client.getBucketLogging( |
Collaborator
There was a problem hiding this comment.
Same for this actually, can't we just get the entire bucket logging instead of one field? or is there some specific need?
Contributor
Author
There was a problem hiding this comment.
In this case Logging enabled is only field of GetBucketLoggingResponse. Should I still return GetBucketLoggingResponse in this case as well?
donghwikim2
commented
Oct 22, 2025
...ws/s3/src/main/java/com/blazebit/query/connector/aws/s3/ServerSideEncryptionRuleFetcher.java
Show resolved
Hide resolved
maxhov
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.