-
Notifications
You must be signed in to change notification settings - Fork 4
Add Gitlab Merge Request data fetcher #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gitlab Merge Request data fetcher #64
Conversation
…y the merged ones
| OffsetDateTime createdAt, | ||
| OffsetDateTime mergedAt, | ||
| String targetBranch, | ||
| String targetProjectId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is targetProjectId? Is it the project it belong to? If so, maybe call it simply projectId?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project_id = the ID of the source project where the branch with the changes lives.
target_project_id = the ID of the target project where the merge request is being opened into.
So in this case, the field name is correct and matches the one used by GitLab in their GraphQL API.
No description provided.