Java: Add client configuration for subscribing to channels.#381
Merged
Yury-Fridlyand merged 8 commits intojava/integ_yuryf_pubsubfrom Jun 26, 2024
Merged
Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
commented
Jun 20, 2024
aaron-congo
approved these changes
Jun 20, 2024
java/client/src/main/java/glide/api/models/configuration/RedisClientConfiguration.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
aaron-congo
approved these changes
Jun 25, 2024
acarbonetto
approved these changes
Jun 25, 2024
| } | ||
|
|
||
| if (configuration.getSubscriptionConfiguration() != null) { | ||
| var subscriptionsBuilder = PubSubSubscriptions.newBuilder(); |
There was a problem hiding this comment.
I would move this logic to the client, and create & the subscriptions in the constructor. Then you can just use a getter here to grab the subscriptions.
Would reduce duplicate code below.
Author
There was a problem hiding this comment.
PubSubSubscriptions is a protobuf class. It is a right place for that.
| setupConnectionRequestBuilderBaseConfiguration(configuration); | ||
| connectionRequestBuilder.setClusterModeEnabled(true); | ||
|
|
||
| if (configuration.getSubscriptionConfiguration() != null) { |
Author
There was a problem hiding this comment.
Unfortunately I didn't find a wayt to move it to another function. Classes are different for standalone and cluster clients.
acarbonetto
reviewed
Jun 25, 2024
| * Optional callback to accept the incoming messages. See {@link MessageCallback}.<br> | ||
| * If not set, messages will be available via TODO method.<br> | ||
| */ | ||
| protected final Optional<MessageCallback> callback; |
There was a problem hiding this comment.
feels like callback subscription configuration and queued configuration could be separate objects
Author
There was a problem hiding this comment.
How do you see that?
Is it good enough?
var regularClient =
RedisClient.CreateClient(
RedisClientConfiguration.builder()
.address(NodeAddress.builder().port(6379).build())
.requestTimeout(3000)
.subscriptionConfiguration(
StandaloneSubscriptionConfiguration.builder()
.subscription(PubSubChannelMode.EXACT, "ch1")
.subscription(PubSubChannelMode.PATTERN, "chat*")
// from there
.build())
.subscriptionCallback(callback) // I moved this
.build())
.get();Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
jamesx-improving
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Java: Add client configuration for subscribing to channels. (#381) * Add client configuartion for subscribing to channels. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * CLIPPY I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Get and store callback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework configuration and add docs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Config rework. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * docs Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * More TODOs for the god of TODOs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add `PUBLISH` and `SPUBLISH` commands. (#391) * Add `PUBLISH` and `SPUBLISH` commands. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix the test. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Java client: receive pubsub messages (#385) * Add client configuartion for subscribing to channels. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * CLIPPY I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Get and store callback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework configuration and add docs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Config rework. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * docs Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Receive pushes (subscibed messages). Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rename a class. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Java: add IT for pubsub (#400) * Add some tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Test fixes. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Uncomment test timeout. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update function signature. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Java: Add client configuration for subscribing to channels. (#381) * Add client configuartion for subscribing to channels. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * CLIPPY I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Get and store callback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework configuration and add docs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Config rework. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * docs Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * More TODOs for the god of TODOs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add `PUBLISH` and `SPUBLISH` commands. (#391) * Add `PUBLISH` and `SPUBLISH` commands. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix the test. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Java client: receive pubsub messages (#385) * Add client configuartion for subscribing to channels. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * CLIPPY I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Get and store callback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework configuration and add docs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Config rework. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * docs Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Receive pushes (subscibed messages). Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rename a class. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Java: add IT for pubsub (#400) * Add some tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Test fixes. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Uncomment test timeout. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update function signature. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
added a commit
that referenced
this pull request
Jun 6, 2025
* Java: Add client configuration for subscribing to channels. (#381) * Add client configuartion for subscribing to channels. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * CLIPPY I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Get and store callback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework configuration and add docs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Config rework. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * docs Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * More TODOs for the god of TODOs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add `PUBLISH` and `SPUBLISH` commands. (#391) * Add `PUBLISH` and `SPUBLISH` commands. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix the test. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Java client: receive pubsub messages (#385) * Add client configuartion for subscribing to channels. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * CLIPPY I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Get and store callback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework configuration and add docs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Config rework. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * docs Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Receive pushes (subscibed messages). Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rename a class. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Java: add IT for pubsub (#400) * Add some tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Test fixes. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Uncomment test timeout. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update function signature. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: valkey-io#1602 and valkey-io#1616 and valkey-io#1650
Tested manually with
And with
redis-cli:publish ch1 $messageTODO (in scope of this PR):
Next feature parts (other PRs):
PUBLISHandSPUBLISHcommands. #391