Skip to content

Pic2card backend/feature synthetic images #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: pic2card-backend/feature-synthetic-images
Choose a base branch
from
Open

Pic2card backend/feature synthetic images #70

wants to merge 10 commits into from

Conversation

@amitramachandran
Copy link

@amitramachandran amitramachandran commented Jan 31, 2022

Changes

  • Have added support for image merges for elements in the synthetic cards
  • Have added support for mandatory image elements.
  • Have removed the random choice choosing the same image element twice for the generating card

Merged image
1

annotations
annotations checked

@amitramachandran amitramachandran marked this pull request as draft February 7, 2022 01:38
@amitramachandran amitramachandran marked this pull request as ready for review February 7, 2022 03:16
haridas
haridas approved these changes Feb 7, 2022
View reviewed changes
Copy link

@haridas haridas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's test and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keerthana786 Keerthana786 Awaiting requested review from Keerthana786

1 more reviewer

@haridas haridas haridas approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amitramachandran @haridas