[wip][do not merge yet] explicit integer division is closer to the original act#175
Open
mengwong wants to merge 3 commits intoBetterRules:masterfrom
Open
[wip][do not merge yet] explicit integer division is closer to the original act#175mengwong wants to merge 3 commits intoBetterRules:masterfrom
mengwong wants to merge 3 commits intoBetterRules:masterfrom
Conversation
but `x // y == floor(x / y)` so this is really quite optional
jvdanker
approved these changes
May 15, 2019
Br3nda
changed the title
Member
|
We need a conversation with the rates rebate team before merging this. They have a cruch deadline right now so not throwing this extra item in their current sprint |
Br3nda
reviewed
May 16, 2019
openfisca_aotearoa/variables/acts/rates_rebates/rates_rebates.py
Outdated
Show resolved
Hide resolved
Br3nda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
but
x // y == floor(x / y)so this is really quite optional