Conversation
Member
Author
Br3nda
reviewed
May 23, 2018
| return persons('ks_contrib_duration', period) >= 3 | ||
|
|
||
| class homestart_grant(Variable): | ||
| class homestart_grant__kiwisaver(Variable): |
Member
There was a problem hiding this comment.
What does the double underscore indicate?
Member
|
I've added some codestyle/linter fixes -- we can squash those commits when we merge |
Br3nda
reviewed
May 29, 2018
| label = u"Years the prospective home buyer has been contributing continuously to their kiwisaver account" | ||
|
|
||
|
|
||
| class contrib_duration__kiwisaver(Variable): |
Member
There was a problem hiding this comment.
This class name is used twice in this file.
…-aotearoa into kiwisaver
Br3nda
changed the title
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening on behalf of @JudyPuff after her team's work during the #BetterRules hackathon 🙂
These changes:
@verbman it looks like this branch was based on some of your previous work on other branches, it would make it much easier to review if it was rebased and only the Home Grant / Kiwisaver-specific stuff was listed. Could you please open PRs for your other branches so we can review them as well? 🙂