Fix MyPy errors for aembedding call_type - CI pass #16360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "aembedding" to Literal type hints in ProxyLogging methods: - pre_call_hook overloads (lines 872, 893, 913) - during_call_hook (line 1052) - _process_guardrail_callback (line 803) Add type: ignore comments where ProxyLogging calls CustomLogger callbacks (lines 1021, 1106) to handle type mismatch between ProxyLogging's broader Literal (includes "aembedding") and CustomLogger's narrower Literal (doesn't include "aembedding"). Related to PR BerriAI#16328 which changed embeddings endpoint to use call_type="aembedding" for async operations.
|
@Chesars is attempting to deploy a commit to the CLERKIEAI Team on Vercel. A member of the Team first needs to authorize it. |
ishaan-jaff
approved these changes
Nov 7, 2025
Contributor
ishaan-jaff
left a comment
ishaan-jaff
left a comment
There was a problem hiding this comment.
@Chesars please make sure the linting passes after this
Contributor
Author
Hi @ishaan-jaff . Ok 👍 |
LingXuanYin
pushed a commit
to talesofai/litellm
that referenced
this pull request
Nov 14, 2025
Add "aembedding" to Literal type hints in ProxyLogging methods: - pre_call_hook overloads (lines 872, 893, 913) - during_call_hook (line 1052) - _process_guardrail_callback (line 803) Add type: ignore comments where ProxyLogging calls CustomLogger callbacks (lines 1021, 1106) to handle type mismatch between ProxyLogging's broader Literal (includes "aembedding") and CustomLogger's narrower Literal (doesn't include "aembedding"). Related to PR BerriAI#16328 which changed embeddings endpoint to use call_type="aembedding" for async operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix MyPy errors for aembedding call_type - CI pass
Relevant PR
#16328
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
Summary
Fixes MyPy type checking errors that were causing CI to fail in
proxy/proxy_server.pylines 5100 and 5109.Problem
The embeddings endpoint uses
call_type="aembedding"(from PR #16328) but the Literal type hints inProxyLoggingdidn't include this value, causing MyPy failures in CI.Solution
"aembedding"to Literal type hints inProxyLoggingmethods (litellm/proxy/utils.py):# type: ignorecomments where needed (lines 1021, 1106)Testing
✅ MyPy passes:
✅ CI should pass with these changes
Related
aembeddingusage)call_typeLiteral definitions are duplicated across 38+ files