Skip to content

Use zig rc compiler when building with zig as linker #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bplaat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use zig rc compiler when building with zig as linker #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bd20c9
Use `zig rc` compiler when building with zig as linker
bplaat Jan 22, 2026
11da865
Add zig GitHub Action job
bplaat Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,18 @@ jobs:
run: |
docker run -v .:/Users/winresource -w /Users/winresource/example xwin cargo xwin build --target x86_64-pc-windows-msvc

zig:
name: Build example on Linux using zig
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions-rust-lang/setup-rust-toolchain@v1
- uses: mlugg/setup-zig@v2
- name: Install x86_64-pc-windows-gnu Rust target
run: rustup target add x86_64-pc-windows-gnu
- name: Install cargo-zigbuild
run: |
curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash
cargo binstall -y cargo-zigbuild
- name: Build example
run: cargo zigbuild --manifest-path example/Cargo.toml --target x86_64-pc-windows-gnu
14 changes: 13 additions & 1 deletion lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,9 @@ impl WindowsResource {
rc.to_str().unwrap().to_string()
};

if is_using_zig_toolchain() {
return self.compile_with_toolkit_msvc(rc.as_str(), &self.output_directory);
}
let target_env = std::env::var("CARGO_CFG_TARGET_ENV").unwrap();
match target_env.as_str() {
"gnu" => self.compile_with_toolkit_gnu(rc.as_str(), &self.output_directory),
Expand All @@ -703,6 +706,8 @@ impl WindowsResource {
fn compile_with_toolkit_msvc(&self, input: &str, output_dir: &str) -> io::Result<()> {
let rc_exe = if let Some(rc_path) = std::env::var_os("RC_PATH") {
PathBuf::from(rc_path)
} else if is_using_zig_toolchain() {
PathBuf::from("zig")
} else if cfg!(unix) {
PathBuf::from("llvm-rc")
} else {
Expand All @@ -722,7 +727,10 @@ impl WindowsResource {
let output = PathBuf::from(output_dir).join("resource.res");
let input = PathBuf::from(input);
let mut command = process::Command::new(&rc_exe);
let command = command.arg(format!("/I{}", env::var("CARGO_MANIFEST_DIR").unwrap()));
if is_using_zig_toolchain() {
command.arg("rc");
}
command.arg(format!("/I{}", env::var("CARGO_MANIFEST_DIR").unwrap()));

if self.add_toolkit_include {
let root = win_sdk_include_root(&rc_exe);
Expand Down Expand Up @@ -761,6 +769,10 @@ impl WindowsResource {
}
}

fn is_using_zig_toolchain() -> bool {
env::var("RUSTC_LINKER").unwrap_or_default().contains("zig")
}

/// Find a Windows SDK
fn get_sdk() -> io::Result<Vec<PathBuf>> {
let output = process::Command::new("reg")
Expand Down