[RIF counter] Remove RIF counter handler instead of removing the whole flex counter group#1
Closed
BasimShalata wants to merge 1 commit into201911from
Closed
[RIF counter] Remove RIF counter handler instead of removing the whole flex counter group#1BasimShalata wants to merge 1 commit into201911from
BasimShalata wants to merge 1 commit into201911from
Conversation
Issue: Issue Rif Counters can not work when removing one router interface sonic-net#729 Root cause: In function FlexCounter::removeRif in 201911 branch, removing the whole instance leads to zero the poll interval and therefore will not receive rif events. As a result of not receiving rif events, the rif thread will not started and therefore the counters table will not filled up. The symptom is N/A values in "show interfaces counters rif" command. Fix: Instead of removing the whole instance, will remove the counter from the m_collectCountersHandlers. Signed-off-by: Basim Shalata <basims@nvidia.com>
volodymyrsamotiy
approved these changes
Jun 1, 2021
BasimShalata
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Issue Rif Counters can not work when removing one router interface sonic-net#729
Issue scenario:
1- create some RIFs if no RIF exist
2- remove all RIFs
3- add new RIF
4- RIF counters are not working for new RIF
Root cause:
Occurred at step sonic-net#2.
In function FlexCounter::removeRif in 201911 branch, removing the whole instance leads to RIF flex counter group to be removed.
After that when adding a new RIF, RIF flex counter group will be created again with zero poll interval
As a result zero poll interval RIF thread will not started and therefore the counters table will not filled up.
The symptom is N/A values in "show interfaces counters rif" command.
Fix:
Instead of removing the whole instance, will remove the counter from the m_collectCountersHandlers.
Signed-off-by: Basim Shalata basims@nvidia.com