Auto-fix .bashrc sourcing during install.sh on macOS/BSD/Solaris

[seefood]

Summary

Automatically sets up .bashrc sourcing during bash-it installation on macOS, BSD, Solaris, and Illumos systems.

This PR builds on the detection capability added in #2342 by implementing the auto-fix during installation.

Problem

On macOS/BSD/Solaris, login shells source .bash_profile or .profile, NOT .bashrc.

Without this fix, users would:

1. Run ./install.sh successfully
2. Open a new terminal or SSH session
3. Find bash-it doesn't load 😞

Many users wouldn't know why or how to fix it.

Solution

During installation, automatically detect and fix .bashrc sourcing:

1. Platform Detection

• Only runs on affected platforms (Darwin, SunOS, Illumos, *BSD)
• Linux users unaffected (no extra prompts)

2. Smart Detection

• Reuses _bash-it-doctor-check-profile-sourcing-grep() from Detect .bashrc sourcing issues on macOS/BSD/Solaris in doctor #2342
• Fast grep-based detection of existing sourcing patterns
• Skips if already configured (no duplicate entries)

3. Interactive Prompt

• Prompts: "Would you like to add .bashrc sourcing to [file]? [Y/n]"
• Shows manual instructions if user declines
• Silent mode (-s flag): auto-accepts (safe default)

4. Safe Modifications

• Backs up profile file with timestamp before modifying
• Uses command cp to bypass user aliases (defensive programming)
• Creates .bash_profile if no profile file exists
• Appends standard BASH_VERSION check snippet

User Experience

Before (macOS user):

$ ./install.sh
Installation finished successfully!
$ # opens new terminal... bash-it doesn't work! 😞

After (macOS user):

$ ./install.sh
...
Warning: .bashrc is not sourced from /Users/me/.bash_profile
On macOS/BSD/Solaris, login shells won't load bash-it without this.

Would you like to add .bashrc sourcing to /Users/me/.bash_profile? [Y/n] y
Backed up /Users/me/.bash_profile to /Users/me/.bash_profile.bak.20251004_193245
✓ Added .bashrc sourcing to /Users/me/.bash_profile

Installation finished successfully!
$ # opens new terminal... bash-it works! 😃

Silent mode:

$ ./install.sh -s
...
✓ Added .bashrc sourcing to /Users/me/.bash_profile
Installation finished successfully!

Code Snippet Added

The installer adds this standard snippet to the profile file:

# Source .bashrc if running bash
if [ -n "$BASH_VERSION" ]; then
	if [ -f "$HOME/.bashrc" ]; then
		. "$HOME/.bashrc"
	fi
fi

Implementation Details

• Reuses detection function from doctor (DRY principle)
• Defensive programming: command cp to bypass aliases
• Timestamp-based backups prevent overwrites
• Shellcheck compliant
• Silent mode compatible

Testing

• ✅ Shellcheck passes
• ✅ Pre-commit hooks pass
• ✅ Detection logic tested (reuses Detect .bashrc sourcing issues on macOS/BSD/Solaris in doctor #2342 code)
• ✅ Silent mode compatible
• ✅ Handles missing profile files
• ✅ Skips if already configured

Closes

Closes #1455 (Solaris/Illumos support)

Related

• Built on Detect .bashrc sourcing issues on macOS/BSD/Solaris in doctor #2342 (doctor detection)
• Completes the solution started in Detect .bashrc sourcing issues on macOS/BSD/Solaris in doctor #2342

---

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

[seefood]

Fixed the ${BASH_VERSION-} usage in 9ec149a per review feedback. Also documented this pattern in CLAUDE.md for future reference. Thanks @akinomyoga!