Conversation
added 5 commits
April 30, 2025 14:47
* 'master' of github.com:Bash-it/bash-it: Update themes/base.theme.bash theme/liquidprompt: don’t clobber `bash-preexec` theme/liquidprompt: use `$THEME_CLOCK_FORMAT` Add conda_or_venv_prompt function Remove unnecessary else clause Add venv prompt to base theme Add virtualenv prompt for robbyrussell theme
* 'master' of github.com:Bash-it/bash-it: lib/utilities: use `$XDG_CACHE_HOME` properly lib/helpers: remove log message from `_command_exists()` et al
This was referenced Apr 30, 2025
akinomyoga
reviewed
Apr 30, 2025
Comment on lines
8
to
10
| IFS="|" | ||
| local params=($1) | ||
| local params=("$1") | ||
| IFS="${OLD_IFS}" |
Contributor
There was a problem hiding this comment.
These three lines obviously try to split $1 with the separator |, so $1 should not be quoted.
Contributor
Author
There was a problem hiding this comment.
yup, I moved to fast obviously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.