Conversation
|
@bmjsmith can you test if this fixes you up? |
|
@akinomyoga anything missed here? |
There was a problem hiding this comment.
I'm not sure if the design of setting those environment variables globally would make sense in the first place because it would affect the normal call of less and other applications internally using less to show information (such as git). One can consider setting these environment variables only for man using env as the corresponding ohmyzsh plugin (ohmyzsh/colored-man-pages) does. Or one can consider setting the environment variables locally in a shell function that calls man as the corresponding oh-my-bash plugin does.
That said, that's not this PR's business. I think the fix in this PR is just fine after addressing the following one point. This should be merged after that.
Co-authored-by: Koichi Murase <[email protected]>
Thank you, yes this works fine. |
* 'master' of github.com:Bash-it/bash-it: (36 commits)
Use ${BASH_VERSION-} for set -u compatibility
Add automatic .bashrc sourcing setup to install.sh
Use 'command' prefix to bypass user aliases in core functions
Update lib/helpers.bash
Document push with upstream tracking in CLAUDE.md
Add .bashrc sourcing detection to bash-it doctor
Add interactive update prompt and colorful output to doctor
Add comprehensive diagnostic summary to bash-it doctor
fix Bash-it#2261 Bash-it#2289 - $LESS is no longer clobbered globally
Fix install test to match updated template
That made little sense to me so I am undoing this.
Fix failing CI tests in gaelic-plugins cleanup
shfmt fix
seems this is how bats prefer it to be run
caught by github sec scanner
shellcheck
battery moved to lib, so should the refering code.
shfmt had a word or two
plugin/ble.sh
lib/battery: rename `plugin/battery`
...
3 participants
this should fix #2261 without breaking any existing value of $LESS
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.