implement #2241 (custom config file during install)#2242
Merged
seefood merged 1 commit intoBash-it:masterfrom Jan 12, 2025
Merged
implement #2241 (custom config file during install)#2242seefood merged 1 commit intoBash-it:masterfrom
seefood merged 1 commit intoBash-it:masterfrom
Conversation
- update `install.sh` & `uninstall.sh` - update `README.md` Signed-off-by: Max Kovgan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install.sh/uninstall.shREADME.mdDescription
CONFIG_FILEifBASH_IT_CONFIG_FILEis passed toinstall.sh/uninstall.shMotivation and Context
this allows not touching user's bash config file, making it easier to detect regressions or compare 2 config files.
#2241
How Has This Been Tested?
the change is pretty trivial, ran
BASH_IT_CONFIG_FILE=.bashrc_bash_it ./install.shresulted in created fle, bashrc untouched.linux: rhel7, ubuntu 22, mac.
doubt there are any other side-effects, please review though.
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.