Tweaks to clean files scripts and file list#2230
Merged
seefood merged 1 commit intoBash-it:masterfrom Nov 6, 2024
Merged
Conversation
seefood
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that all files under
lib/*were manually specified inclean_files.txt. I refactored that to the first section.When running the
lint_clean_files.shscript, I receieve the following message:Because the previuos
--max-args/-nvalue is ignored anyways, and to remove the warning, I removed that option from the script.Motivation and Context
This simplifes the cleaning files workflow.
How Has This Been Tested?
By executing
./lint_clean_files.sh. And double-checking to ensure that directories are, in fact, supported byclean_files.txt.Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.