Fix duplicate declaration of grm, update grb<*>#2220
Merged
seefood merged 2 commits intoBash-it:masterfrom Nov 7, 2024
Merged
Conversation
Contributor
Author
8 tasks
Contributor
Author
|
This PR fixes a bug. The changes have been extensively discussed. The only thing missing it someone to press the Merge button. Please? 🙏 |
Contributor
Author
|
Can anyone clarify why for macos-11 tests are skipped, which makes the test job fail? 52 tests are skipped: (3 + 46 + 3)
Log excerpt (macos-11)Skipped tests (macos-11)Is this relevant and needs fixing, or is this an operational error or a flaky test suite? |
Member
|
@bittner I don't have an answer for why the macos tests do this, but it is my understanding that yes, they need fixing. |
Contributor
Author
|
Can we first merge all the other git-alias related PRs? My hope is that after rebasing onto those changesets the tests run successfully, PRs like this one either succeed (by magic, i.e. we have flaky tests) or the reasons for failing will become clearer. |
seefood
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates the
git rebasealiases thus fixing the unintended overloading ofgrm.gdelis outphased as an unclear, non-intuitive sibling ofgbD(git branch --delete --force).Motivation and Context
grmis an alias forgit rebasedue to being redeclared after the firstgrm(git rm). The redeclaration is a bug.Closes #2160.
How Has This Been Tested?
n/a
Screenshots (if appropriate):
n/a
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.