Update variable name to match projects.plugin.bash#2161
Merged
NoahGorny merged 1 commit intoBash-it:masterfrom Sep 13, 2022
Merged
Update variable name to match projects.plugin.bash#2161NoahGorny merged 1 commit intoBash-it:masterfrom
NoahGorny merged 1 commit intoBash-it:masterfrom
Conversation
The projects plugin was changed to reference `BASH_IT_PROJECT_PATHS` but the completion was still using `PROJECT_PATHS`
davidpfarrell
approved these changes
Aug 30, 2022
Contributor
davidpfarrell
left a comment
There was a problem hiding this comment.
Best I can tell this looks legit and a good catch !
Contributor
Author
|
@davidpfarrell What's the next step here? |
Contributor
We're waiting for those who do the merges to find time in their busy lives to review the approved PRs and (hopefully) merge them or comment if they need any changes / clarifications / etc. |
Member
|
Thanks @brianphillips |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The projects plugin was changed to reference
BASH_IT_PROJECT_PATHSbut the completion was still usingPROJECT_PATHSMotivation and Context
This fixes a regression in the project completion code due to a refactor in the project plugin code
How Has This Been Tested?
Tested locally
Screenshots (if appropriate):
n/a
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.